Add EventService CRUD methods #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following: * Create event * Get event by ID * Update event * Delete event by ID
7 tasks
|
Visit the preview URL for this PR (updated for commit e6d0ec6): https://uasc-ceebc--pr767-702-backend-create-a-afv7s7ud.web.app (expires Sat, 07 Sep 2024 12:00:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 36296ceaed1d43e92e7d5e81a72a7bd987560bfa |
choden-dev
reviewed
Aug 28, 2024
Removed document ID when fetching an event as realised was not needed. Man its the timestamps again...
Includes add, get, update and delete methods.
https://github.com/UoaWDCC/uasc-web into 702-backend-create-an-eventservice-for-crud-on-events
choden-dev
reviewed
Aug 30, 2024
Added tests in EventService.test.ts for sub collection, EventReservation.
Seems to work in tests so didn't need to use DateUtil
…pdate event service Changed FirestoreCollections to 2 different collections: * FirestoreCollection - just the general collections * FirestoreSubcollection - collections under a "general" collection Created individual Firestore.ts file to hold the main adapter and have the subcollection and collection import it. Updated EventService for the subcollection changes.
choden-dev
approved these changes
Aug 30, 2024
The `deleteEvent` function from EventService will now delete all reservations if they exist. Added tests to test functionalities. 1. Tests deleting all reservations under a deleted event 2. Checks if other reservations are deleted that are unrelated to a deleted event
choden-dev
approved these changes
Aug 31, 2024
| expect(fetchedReservation2).toBe(undefined) | ||
| }) | ||
|
|
||
| it("Should not delete other reservations when deleting an event document", async () => { |
Added jsdoc!
|
jeffplays2005
deleted the
702-backend-create-an-eventservice-for-crud-on-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following: